NameBuilder concurrency issue fix#5
Merged
alex-kulakov merged 3 commits intoDataObjects-NET:masterfrom Feb 7, 2020
Merged
Conversation
vchirikov
pushed a commit
to vchirikov/dataobjects-net
that referenced
this pull request
Feb 4, 2020
Add IsPackable=false to Weaver.csproj
vchirikov
previously approved these changes
Feb 5, 2020
Contributor
|
Thank you for the contribution. But there are some changes of the part of code you've changed committed to master so it's better to apply your changes to updated class. Tests of caching were also added so you can check your changes with them. Also notice that instance read-only fields are grouped but your static read-only fields breaks the order. Could you please put static read-only field before group of instance read-only fields and make the |
# Conflicts: # Orm/Xtensive.Orm/Orm/Providers/NameBuilder.cs
Contributor
Author
|
PR is updated in according to code review comments |
alex-kulakov
approved these changes
Feb 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.